Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 修正 needConfirm 为 false 的场景下，preset 选择失效的问题 #4792

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix: 🐛 修正 needConfirm 为 false 的场景下，preset 选择失效的问题 #4792

wants to merge 3 commits into from

Conversation

Cat1007
Copy link
Collaborator

@Cat1007 Cat1007 commented Nov 29, 2024

🤔 这个 PR 的性质是？

  • 日常 bug 修复

🔗 相关 Issue

#4767

💡 需求背景和解决方案

原逻辑浮窗关闭时，needConfirm 为 false时，会读入 input 结果并将其设置到 value，preset 选择后只更改了 value，未对 input 进行修改，导致关闭时被旧的 input 值覆盖。

📝 更新日志

  • fix(DatePicker): 修正 needConfirm 为 false 的场景下，preset 选择失效的问题

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 29, 2024 •
edited
Loading

完成

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PengYYYYY PengYYYYY PengYYYYY left review comments

@chaishi chaishi Awaiting requested review from chaishi chaishi is a code owner

@xiaosansiji xiaosansiji Awaiting requested review from xiaosansiji xiaosansiji is a code owner

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@LeeJim LeeJim Awaiting requested review from LeeJim LeeJim is a code owner

@uyarn uyarn Awaiting requested review from uyarn uyarn is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cat1007 @PengYYYYY