-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Table): 修复Table组件没有提供expandedRowKeys的绑定会报错的问题(issue #1704) #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
您好,请补充一下changelog |
是这个issue嘛 #1704 |
具体解决了什么问题,提供一下 issue,或者问题描述 |
是的 |
PengYYYYY
approved these changes
Sep 23, 2022
MyZhouGit
changed the title
解决因为没有提供扩展属性导致出现NPE的错误的问题
fix(Table): 修复Table组件没有提供expandedRowKeys的绑定会报错的问题(issue #1705)
Sep 26, 2022
MyZhouGit
changed the title
fix(Table): 修复Table组件没有提供expandedRowKeys的绑定会报错的问题(issue #1705)
fix(Table): 修复Table组件没有提供expandedRowKeys的绑定会报错的问题(issue #1704)
Sep 26, 2022
chaishi
reviewed
Sep 26, 2022
@@ -86,7 +86,7 @@ export default function useRowExpand(props: TdPrimaryTableProps, context: SetupC | |||
p: TableExpandedRowParams<TableRowData> & { tableWidth: number; isWidthOverflow: boolean }, | |||
) => { | |||
const rowId = get(p.row, props.rowKey || 'id'); | |||
if (!tExpandedRowKeys.value.includes(rowId)) return null; | |||
if (tExpandedRowKeys?.value || !tExpandedRowKeys.value.includes(rowId)) return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没改对,我接着处理
This was referenced Sep 27, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
fix(Table): 修复不提供
expandedRowKeys
的绑定会报错本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单