-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TimePicker): 修复边界滚动异常问题 #1426
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 78e6817.
…n-react into fix/time-picker-scrolling
HelKyle
requested review from
honkinglin,
uyarn and
carolin913
as code owners
September 3, 2022 15:26
Codecov Report
@@ Coverage Diff @@
## develop #1426 +/- ##
===========================================
+ Coverage 61.00% 62.86% +1.86%
===========================================
Files 1030 1030
Lines 17933 17904 -29
Branches 4121 4089 -32
===========================================
+ Hits 10940 11256 +316
+ Misses 6993 6648 -345
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
uyarn
approved these changes
Sep 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@HelKyle 刚刚只顾着看边界了 发现这个改动会引入其他问题
辛苦再修复这两个引入的异常再提交PR |
uyarn
added a commit
that referenced
this pull request
Sep 3, 2022
Merged
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Tencent/tdesign-vue-next#1012
关联子仓库:Tencent/tdesign-common#802
🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
fix(TimePicker): 修复边界滚动异常问题
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单