Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): onChange trigger twice when uncheck #1422

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

Lmmmmmm-bb
Copy link
Contributor

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#1421

💡 需求背景和解决方案

📝 更新日志

  • fix(radio): onChange trigger twice when uncheck

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@codecov-commenter
Copy link

Codecov Report

Merging #1422 (2054186) into develop (8a9ef3a) will increase coverage by 1.88%.
The diff coverage is 52.34%.

@@             Coverage Diff             @@
##           develop    #1422      +/-   ##
===========================================
+ Coverage    61.00%   62.88%   +1.88%     
===========================================
  Files         1030     1031       +1     
  Lines        17933    17983      +50     
  Branches      4121     4135      +14     
===========================================
+ Hits         10940    11309     +369     
+ Misses        6993     6674     -319     
Impacted Files Coverage Δ
src/alert/_example/operation.jsx 60.00% <0.00%> (-40.00%) ⬇️
src/collapse/_usage/index.jsx 0.00% <0.00%> (ø)
src/config-provider/_example/global.jsx 100.00% <ø> (ø)
src/date-picker/DateRangePickerPanel.tsx 10.29% <0.00%> (-0.08%) ⬇️
src/date-picker/_example/panel.jsx 33.33% <0.00%> (-16.67%) ⬇️
src/date-picker/base/Header.tsx 42.66% <0.00%> (-1.17%) ⬇️
src/dialog/RenderDialog.tsx 65.51% <0.00%> (+5.17%) ⬆️
src/form/Form.tsx 67.85% <0.00%> (ø)
src/message/_example/close-function.jsx 41.66% <ø> (ø)
src/popconfirm/_example/describe.jsx 100.00% <ø> (ø)
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2022

完成

@honkinglin honkinglin merged commit 7698c35 into Tencent:develop Sep 5, 2022
@github-actions github-actions bot mentioned this pull request Sep 6, 2022
16 tasks
@Lmmmmmm-bb Lmmmmmm-bb deleted the fix/radio-allowuncheck branch September 6, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants