Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/action-sheet #637

Merged
merged 39 commits into from
May 24, 2023
Merged

Conversation

brianzhang
Copy link
Contributor

@brianzhang brianzhang commented Apr 25, 2023

🤔 这个 PR 的性质是?

  • 新特性提交

🔗 相关 Issue

💡 需求背景和解决方案

背景:
属性:移除 type,新增 align
事件:close 事件参数变更

📝 更新日志

  • break(ActionSheet): 移除 type 属性

  • break(ActionSheet): close 事件参数变更

  • feat(ActionSheet): 新增 aligndescription 属性

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2023

完成

@anlyyao anlyyao mentioned this pull request Apr 26, 2023
@anlyyao
Copy link
Collaborator

anlyyao commented Apr 26, 2023

@brianzhang 需要 rebase dev 一下哈

@anlyyao
Copy link
Collaborator

anlyyao commented Apr 27, 2023

@brianzhang

问题:

  1. 宫格型 翻页时会导致整个窗体关闭
  2. 左边的演示代码和右边的预览效果,需要一一对齐哦,方便取用
  3. 冲突

src/action-sheet/demos/grid-multiple.vue Show resolved Hide resolved
src/action-sheet/action-sheet.vue Outdated Show resolved Hide resolved
src/action-sheet/action-sheet.vue Outdated Show resolved Hide resolved
@anlyyao anlyyao added the in progress 正在处理中 label May 15, 2023
@anlyyao
Copy link
Collaborator

anlyyao commented May 16, 2023

@brianzhang 囧 common冲突了

@anlyyao
Copy link
Collaborator

anlyyao commented May 16, 2023

遗留问题:

  1. 宫格型-多页 示例, 翻页会导致窗体直接关闭。

补充问题:

  1. 徽标位置不正确
  2. list-item中的文本字重不对,应该是400
  3. 底部取消按钮文本,字重也是400
  4. common冲突, 需rebase dev
企业微信截图_91c04b16-037b-4316-8017-67eeb5b7f0d0

正确视觉如下:

截屏2023-05-16 10 55 23

@brianzhang
Copy link
Contributor Author

brianzhang commented May 17, 2023

宫格型-多页 示例, 翻页会导致窗体直接关闭问题,经过排查后需swiper组件在初始化时要计算正确的滑动宽度,并阻止滑动事件冒泡。

action-sheet 组件已添加事件冒泡阻止

@click.prevent="handleSelected(i * count + index)"

排查情况如下

由于swiper组件,初始化展示后 在popup组件中滑动区块就无法正常滑动。热更新一下视图代码就能正常滑动了。 排查后发现是swiper滑块未在初始状态计算出滑块距离。
企业微信截图_fae341f1-3fcd-45c6-8ada-1a31eaf12210

正常情况下:两页滑动
左右滑动这里打印出来的值为:onTouchMove: 0 375 138 -138

异常情况:
左右滑动打印出来的值为:onTouchMove: 0 0 175 -175

@anlyyao
Copy link
Collaborator

anlyyao commented May 19, 2023

补充问题2:

  1. 补充函数式调用
  2. _common 冲突

@brianzhang
Copy link
Contributor Author

已全部处理

@anlyyao anlyyao merged commit 2e0daea into Tencent:develop May 24, 2023
@anlyyao anlyyao removed the in progress 正在处理中 label May 30, 2023
@github-actions github-actions bot mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants