Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tag): new tag #615

Merged
merged 19 commits into from
Apr 24, 2023
Merged

refactor(tag): new tag #615

merged 19 commits into from
Apr 24, 2023

Conversation

yaogengzhu
Copy link
Collaborator

@yaogengzhu yaogengzhu commented Apr 21, 2023 •
edited by anlyyao
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • break(CheckTag): 移除 shape 属性
  • feat(CheckTag): 新增 variant 属性

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@yaogengzhu yaogengzhu changed the title refactor(tag): 改造tag组件 refactor(tag): new tag Apr 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2023 •
edited
Loading

完成

@yaogengzhu
Copy link
Collaborator Author

文档：Tencent/tdesign-common#1296

anlyyao
anlyyao reviewed Apr 23, 2023
View reviewed changes
src/tag/demos/checkable.vue Outdated Show resolved Hide resolved
src/tag/demos/checkable.vue Outdated Show resolved Hide resolved
src/tag/demos/checkable.vue Outdated Show resolved Hide resolved
@anlyyao
Copy link
Collaborator

anlyyao commented Apr 23, 2023 •
edited
Loading

问题：

  1. mobile vue中demo文件命名参考下小程序端，并复用小程序端的 .md 代码演示部分内容

企业微信截图_d181c4e3-544a-4977-8263-e6bbef3c352f

  1. 组件尺寸第二个示例辛苦调整下间距，一行呈现

截屏2023-04-23 10 40 03

  1. npm run build 构建失败，需要修复 ts 类型错误
  2. 单词拼写错误
  3. fork的common库，修改后需要单独提pr到 tdesign-common 库

anlyyao
anlyyao reviewed Apr 23, 2023
View reviewed changes
src/tag/check-tag.vue Outdated Show resolved Hide resolved
@anlyyao
Copy link
Collaborator

anlyyao commented Apr 23, 2023

@yaogengzhu 邮箱校验失败

@yaogengzhu yaogengzhu requested a review from anlyyao April 23, 2023 05:31
@yaogengzhu
Copy link
Collaborator Author

image

image

这里 contentIsArray 已判断是否是数组， 看起来还得 & content 一个条件了

anlyyao
anlyyao reviewed Apr 23, 2023
View reviewed changes
src/tag/demos/checkable.vue Show resolved Hide resolved
src/tag/demos/theme.vue Show resolved Hide resolved
src/tag/demos/type.vue Outdated Show resolved Hide resolved
src/tag/demos/closable.vue Outdated Show resolved Hide resolved
@anlyyao anlyyao merged commit d6cdc21 into Tencent:develop Apr 24, 2023
@anlyyao anlyyao mentioned this pull request Apr 24, 2023
Closed
@github-actions github-actions bot mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anlyyao anlyyao anlyyao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaogengzhu @anlyyao