Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog): 修复示例代码运行问题 #289

Merged
merged 2 commits into from
Aug 22, 2022
Merged

fix(dialog): 修复示例代码运行问题 #289

merged 2 commits into from
Aug 22, 2022

Conversation

zyqq
Copy link

@zyqq zyqq commented Aug 21, 2022 •
edited by anlyyao
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#279

💡 需求背景和解决方案

  1. 解决dialog示例代码运行时，无法显示弹窗的问题
  2. 将文档示例代码和正常运行的右侧移动端源代码保持一致，即v-model改为v-model:visible

📝 更新日志

  • fix(Dialog): 修复 demo 示例弹窗不显示问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

完成

@honkinglin honkinglin merged commit 12e7d84 into Tencent:develop Aug 22, 2022
@github-actions github-actions bot mentioned this pull request Aug 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honkinglin honkinglin honkinglin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zyqq @honkinglin