Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/toast loading icon #241

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Fix/toast loading icon #241

merged 2 commits into from
Jul 19, 2022

Conversation

douxpang
Copy link
Contributor

🤔 这个 PR 的性质是？

  • [ ✅] 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#227

💡 需求背景和解决方案

  1. toast组件之前有Toast({ }) 和 Toast.success/fail/loading. 两种使用方式。 第二种方式的使用会使toast缺失相关icon
  2. 无新增用法

📝 更新日志

无

  • fix(组件名称): 处理问题或特性描述 ...

toast

Changelog：修复toast内置方法icon不显示问题

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • [✅ ] 文档已补充或无须补充
  • [✅] 代码演示已提供或无须提供
  • [✅] TypeScript 定义已补充或无须补充
  • [✅] Changelog 已提供或无须提供

douxpang added 2 commits July 18, 2022 19:48
@douxpang
fix(toast): fix the problem that toast has no icon
4190848 
fix the problem that toast has no icon when we use the build-in methods of toast

fix Tencent#227
@douxpang
fix(toast): fix the problem that toast has no icon
0bbc7fe 
fix the problem that toast has no icon when we use the build-in methods of toast

fix Tencent#227
@github-actions
Copy link
Contributor

完成

@Dengzygx Dengzygx merged commit 4967cd1 into Tencent:develop Jul 19, 2022
@github-actions github-actions bot mentioned this pull request Jul 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dengzygx Dengzygx Dengzygx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@douxpang @Dengzygx