Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): disabled attribute does not take effect #1273

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

wangyang0210
Copy link

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

tdesign-vue-next #2690

💡 需求背景和解决方案

📝 更新日志

fix(menu): 修复disabled属性在expandType为popup时样式不生效

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link

github-actions bot commented Apr 14, 2023

tdesign-vue preview 地址:(如果你有 DOM 变动请自行在对应技术栈仓库中发起 PR)
完成

@xiaosansiji
Copy link
Collaborator

感觉可以通过调整下 disable 样式出现在 less 文件中的顺序来调整下?加 !important 破坏了整体样式代码可读性(不能顺序向下决定优先级)也可能会导致用户覆盖样式补方便

style/web/components/menu/_index.less Outdated Show resolved Hide resolved
@wangyang0210 wangyang0210 force-pushed the fix/menu_extend-type_disabled branch from 1ef78c1 to 7564264 Compare April 21, 2023 10:55
@wangyang0210 wangyang0210 force-pushed the fix/menu_extend-type_disabled branch from 7564264 to be14ad8 Compare April 21, 2023 11:01
@uyarn uyarn merged commit 56efac1 into Tencent:develop Apr 25, 2023
oljc pushed a commit to oljc/tdesign-common that referenced this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants