Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc optimize metadata router #192

Merged
merged 1 commit into from
May 23, 2022

Conversation

lepdou
Copy link
Collaborator

@lepdou lepdou commented May 23, 2022

  1. fix router rest template strong dependency on RouterLabelResolver
  2. optimize RouterLabelResolver to list
  3. add metadata-transfer dependency for router

PR Type

Describe what this PR does for and how you did.

Does this PR be associated with issue? If so, please adding the issue link below.

Note

Checklist

  • Code compiles correctly
  • Pull Request has submit to 2020.0 and Greenwich
  • Create at least one junit test if possible
  • All tests passing
  • Extend documentation if necessary
  • Add myself / the copyright holder to the AUTHORS file

@lepdou lepdou force-pushed the h/optimize_metadata_router branch 2 times, most recently from 539a35d to 4c1ba7b Compare May 23, 2022 06:34
@lepdou lepdou requested a review from SkyeBeFreeman May 23, 2022 06:43
MetadataLocalProperties metadataLocalProperties,
RouterRuleLabelResolver routerRuleLabelResolver) {
this.resolver = resolver;
if (routerLabelResolvers != null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CollectionsUtils.isEmpty来判断?

@lepdou lepdou force-pushed the h/optimize_metadata_router branch 2 times, most recently from 0775d3e to cd087f8 Compare May 23, 2022 07:01
2. optimize RouterLabelResolver to list
3. add metadata-transfer dependency for router
@lepdou lepdou force-pushed the h/optimize_metadata_router branch from cd087f8 to d494940 Compare May 23, 2022 07:07
Copy link
Collaborator

@SkyeBeFreeman SkyeBeFreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SkyeBeFreeman SkyeBeFreeman merged commit d6e2923 into Tencent:main May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants