Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support lossless config from console & support warmup. #1446

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

SkyeBeFreeman
Copy link
Collaborator

PR Type

Describe what this PR does for and how you did.

feat: support lossless config from console & support warmup

Adding the issue link (#xxx) if possible.

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2023.
  • Will pull request to branch of 2022.
  • Will pull request to branch of 2021.
  • Will pull request to branch of 2020.
  • Will pull request to branch of hoxton.

@SkyeBeFreeman SkyeBeFreeman added this to the 2.0.0.0 milestone Oct 28, 2024
Copy link
Collaborator

@shedfreewu shedfreewu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.22%. Comparing base (56ad635) to head (e08efff).
Report is 1 commits behind head on 2021.

Files with missing lines Patch % Lines
...plugin/lossless/config/LosslessConfigModifier.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2021    #1446      +/-   ##
============================================
+ Coverage     69.20%   69.22%   +0.02%     
  Complexity        2        2              
============================================
  Files           308      309       +1     
  Lines          7335     7353      +18     
  Branches        872      876       +4     
============================================
+ Hits           5076     5090      +14     
- Misses         1823     1826       +3     
- Partials        436      437       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkyeBeFreeman SkyeBeFreeman merged commit 5aaf5b6 into Tencent:2021 Oct 28, 2024
9 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the 21/lossless branch October 28, 2024 08:40
SkyeBeFreeman added a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants