Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:upgrade api circuit breaker. #1438

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

SkyeBeFreeman
Copy link
Collaborator

@SkyeBeFreeman SkyeBeFreeman commented Sep 26, 2024

PR Type

Feature.

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

closes #1439

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2023.
  • Will pull request to branch of 2022.
  • Will pull request to branch of 2021.
  • Will pull request to branch of 2020.
  • Will pull request to branch of hoxton.

@SkyeBeFreeman SkyeBeFreeman added this to the 2.0.0.0 milestone Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 39.35970% with 322 lines in your changes missing coverage. Please review.

Project coverage is 69.13%. Comparing base (b82ff9e) to head (7a04dcb).
Report is 1 commits behind head on 2022.

Files with missing lines Patch % Lines
...laris/extend/consul/ConsulDiscoveryProperties.java 25.00% 164 Missing and 1 partial ⚠️
...ig/extend/tsf/TsfCoreEnvironmentPostProcessor.java 7.59% 72 Missing and 1 partial ⚠️
...xt/config/extend/tsf/TsfContextConfigModifier.java 0.00% 18 Missing ⚠️
...s/context/config/extend/tsf/TsfCoreProperties.java 16.66% 13 Missing and 2 partials ⚠️
...s/extend/consul/ConsulDiscoveryConfigModifier.java 76.36% 3 Missing and 10 partials ⚠️
...er/gateway/PolarisCircuitBreakerFilterFactory.java 81.39% 2 Missing and 6 partials ⚠️
...registry/TsfPortPolarisRegistrationCustomizer.java 0.00% 7 Missing ⚠️
...loud/common/tsf/ConditionalOnTsfConsulEnabled.java 45.45% 5 Missing and 1 partial ⚠️
...oud/polaris/extend/consul/ConsulDiscoveryUtil.java 16.66% 3 Missing and 2 partials ⚠️
...config/extend/tsf/TsfInstanceMetadataProvider.java 0.00% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##               2022    #1438      +/-   ##
============================================
+ Coverage     64.70%   69.13%   +4.42%     
  Complexity        2        2              
============================================
  Files           323      308      -15     
  Lines          7543     7332     -211     
  Branches        910      870      -40     
============================================
+ Hits           4881     5069     +188     
+ Misses         2247     1826     -421     
- Partials        415      437      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewshan andrewshan merged commit c5f318d into Tencent:2022 Sep 26, 2024
5 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the 22/upgrade-api-cb branch September 26, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API 熔断支持 HTTP Method 的判断
2 participants