Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:add zero protection. #1278

Merged
merged 11 commits into from
May 21, 2024
Merged

Conversation

SkyeBeFreeman
Copy link
Collaborator

PR Type

Feature.

Describe what this PR does for and how you did.

Adding the issue link (#xxx) if possible.

closes #1277

Note

Checklist

  • Add information of this PR to CHANGELOG.md in root of project.
  • Add documentation in javadoc or comment below the PR if necessary.

Checklist (Optional)

  • Will pull request to branch of 2023.0.
  • Will pull request to branch of 2022.0.
  • Will pull request to branch of 2021.0.
  • Will pull request to branch of 2020.0.
  • Will pull request to branch of hoxton.

@SkyeBeFreeman SkyeBeFreeman added this to the 1.14.0 milestone Apr 18, 2024
@SkyeBeFreeman SkyeBeFreeman marked this pull request as draft April 18, 2024 11:18
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 48.48485% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 77.55%. Comparing base (0fc1d2d) to head (9366665).
Report is 2 commits behind head on 2022.0.

Current head 9366665 differs from pull request most recent head 1f9e2ed

Please upload reports for the commit 1f9e2ed to get more accurate results.

Files Patch % Lines
.../configdata/PolarisConfigDataLocationResolver.java 25.00% 8 Missing and 1 partial ⚠️
...pter/extension/PolarisConfigServiceLoaderUtil.java 30.00% 5 Missing and 2 partials ⚠️
...cent/cloud/polaris/PolarisDiscoveryProperties.java 50.00% 4 Missing ⚠️
...m/tencent/cloud/polaris/context/ModifyAddress.java 40.00% 0 Missing and 3 partials ⚠️
...nt/cloud/polaris/config/ConfigurationModifier.java 33.33% 1 Missing and 1 partial ⚠️
...laris/config/adapter/PolarisConfigFileLocator.java 81.81% 1 Missing and 1 partial ⚠️
...ud/polaris/extend/consul/ConsulConfigModifier.java 0.00% 1 Missing and 1 partial ⚠️
...polaris/extend/consul/ConsulContextProperties.java 50.00% 2 Missing ⚠️
...nt/cloud/polaris/registry/PolarisRegistration.java 50.00% 1 Missing and 1 partial ⚠️
...loud/polaris/contract/PolarisContractReporter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             2022.0    #1278      +/-   ##
============================================
- Coverage     77.76%   77.55%   -0.22%     
- Complexity     1791     1797       +6     
============================================
  Files           273      273              
  Lines          6256     6304      +48     
  Branches        763      771       +8     
============================================
+ Hits           4865     4889      +24     
- Misses          976      989      +13     
- Partials        415      426      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkyeBeFreeman SkyeBeFreeman marked this pull request as ready for review April 21, 2024 10:03
@SkyeBeFreeman SkyeBeFreeman marked this pull request as draft April 24, 2024 13:57
@SkyeBeFreeman SkyeBeFreeman marked this pull request as ready for review May 21, 2024 03:05
Copy link
Collaborator

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewshan andrewshan merged commit 832f5bc into Tencent:2022.0 May 21, 2024
4 checks passed
@SkyeBeFreeman SkyeBeFreeman deleted the 2022/zero-protect branch May 21, 2024 07:00
fuyuwei01 pushed a commit to fuyuwei01/spring-cloud-tencent that referenced this pull request Aug 14, 2024
* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.
fuyuwei01 pushed a commit to fuyuwei01/spring-cloud-tencent that referenced this pull request Aug 27, 2024
* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.

* feat:add zero protection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持零实例保护
2 participants