Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

多插件打包时应该检查出没有应用shadow plugin的插件工程 #734

Closed
shifujun opened this issue Dec 30, 2021 · 0 comments · Fixed by #753
Closed

多插件打包时应该检查出没有应用shadow plugin的插件工程 #734

shifujun opened this issue Dec 30, 2021 · 0 comments · Fixed by #753
Labels
enhancement New feature or request help wanted Extra attention is needed PR welcome 欢迎贡献代码

Comments

@shifujun
Copy link
Collaborator

有时接入多插件时会因为不用配置DSL而忘记写这行，导致打包的插件没有被transform修改，出现奇怪的问题一时无法理解。

Shadow/projects/sample/source/sample-plugin/sample-base/build.gradle

Line 20 in 3d8a6d9

apply plugin: 'com.tencent.shadow.plugin'

package任务应该可以检查这些工程是否应用了插件。
@shifujun shifujun added enhancement New feature or request help wanted Extra attention is needed PR welcome 欢迎贡献代码 labels Dec 30, 2021
shifujun added a commit to shifujun/Shadow that referenced this issue Jan 6, 2022
@shifujun
feat(core.loader): 找不到PluginManifest时提示应用插件
95e6df2 
当前打包任务设计不够合理，无法提取出各插件apk的生成工程，
所以不能检查插件apk工程是否应用了Shadow Gradle插件。

close Tencent#734
@shifujun shifujun mentioned this issue Jan 6, 2022
Merged
shifujun added a commit that referenced this issue Jan 11, 2022
@shifujun
feat(core.loader): 找不到PluginManifest时提示应用插件
445f4d9 
当前打包任务设计不够合理，无法提取出各插件apk的生成工程，
所以不能检查插件apk工程是否应用了Shadow Gradle插件。

close #734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed PR welcome 欢迎贡献代码
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core.loader): 找不到PluginManifest时提示应用插件 shifujun/Shadow
1 participant
@shifujun