Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): revert rename hippy prefix for compatibility #3685

Merged
merged 2 commits into from
Jan 3, 2024
Merged

fix(ios): revert rename hippy prefix for compatibility #3685

merged 2 commits into from
Jan 3, 2024

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Dec 25, 2023

Before submitting a new pull request, please make sure:

  • Test cases have been added/updated/passed for the code you will submit.
  • Documentation has added or updated.
  • Commit message is following the Convention Commit guideline with maximum 72 characters.
  • Squash the repeat code commits, short patches are welcome.

@wwwcg wwwcg requested a review from ruifanyuan as a code owner December 25, 2023 13:29
@github-actions github-actions bot added renderer: native size: m Denotes a PR that changes 100-499 lines labels Dec 25, 2023
@hippy-service Hippy Service
Copy link

hippy-service bot commented Dec 25, 2023

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@wwwcg wwwcg added the action(squash-merge) Squash and merge action label Dec 26, 2023
@hippy-actions Hippy Actions
Copy link

hippy-actions bot commented Dec 26, 2023

⚠️ squash-merge action execution failed, because of cannot squash and merge your own pull request.

Please check the following details:

(empty response)

@wwwcg

@hippy-actions hippy-actions bot added action(squash-merge): failed Squash and merge action execution failed and removed action(squash-merge) Squash and merge action labels Dec 26, 2023
@hippy-service Hippy Service
Copy link

hippy-service bot commented Jan 3, 2024

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@wwwcg wwwcg enabled auto-merge (rebase) January 3, 2024 13:03
@wwwcg wwwcg disabled auto-merge January 3, 2024 13:04
@wwwcg wwwcg removed the action(squash-merge): failed Squash and merge action execution failed label Jan 3, 2024
@wwwcg wwwcg merged commit e377647 into Tencent:main Jan 3, 2024
18 of 21 checks passed
@wwwcg wwwcg deleted the hippy3_fix_28 branch January 12, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruifanyuan ruifanyuan ruifanyuan approved these changes

Assignees
No one assigned
Labels
renderer: native size: m Denotes a PR that changes 100-499 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwwcg @ruifanyuan