Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): fix context leak when using shared engine #3451

Merged
merged 4 commits into from
Aug 25, 2023
Merged

fix(ios): fix context leak when using shared engine #3451

merged 4 commits into from
Aug 25, 2023

Conversation

wwwcg
Copy link
Collaborator

@wwwcg wwwcg commented Aug 21, 2023

Pre-PR Checklist

  • I added/updated relevant documentation.
  • I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
  • I squashed the repeated code commits.
  • I signed the [CLA].
  • I added/updated test cases to check the change I am making.
  • All existing and new tests are passing.

@wwwcg wwwcg requested a review from ozonelmy as a code owner August 21, 2023 12:17
@github-actions github-actions bot added framework: ios doc: example size: s Denotes a PR that changes 10-99 lines labels Aug 21, 2023
@hippy-service
Copy link

hippy-service bot commented Aug 21, 2023

Hi, @wwwcg. Thanks for your PR! 👏

🏷️ You can leave a comment in this PR with #help tag when you need help (e.g. some status checks run failed due to internal issue), admin team members will help asap.

@hippy-service
Copy link

hippy-service bot commented Aug 24, 2023

🎉 It seems that this pull request has been approved by all required reviewers. But it has more than one normal commit, I will notify admin team member to merge it manually, please wait a moment.

@ozonelmy ozonelmy enabled auto-merge (rebase) August 25, 2023 03:16
@zealotchen0 zealotchen0 added the action(squash-merge) Squash and merge action label Aug 25, 2023
@hippy-actions hippy-actions bot disabled auto-merge August 25, 2023 03:24
@hippy-actions hippy-actions bot enabled auto-merge (squash) August 25, 2023 03:24
@hippy-actions hippy-actions bot removed the action(squash-merge) Squash and merge action label Aug 25, 2023
@hippy-actions hippy-actions bot merged commit eee3687 into Tencent:master Aug 25, 2023
29 of 31 checks passed
wwwcg added a commit to wwwcg/Hippy that referenced this pull request Aug 28, 2023
@wwwcg @open-hippy
fix(ios): fix context leak when using shared engine (Tencent#3451)
468fcb3 
* chore(ios): fix demo release build error

* fix(ios): js context leak when using shared engine

---------

Co-authored-by: OpenHippy <[email protected]>
zealotchen0 pushed a commit that referenced this pull request Sep 12, 2023
@wwwcg @open-hippy @zealotchen0
fix(ios): fix context leak when using shared engine (#3451)
194b598 
* chore(ios): fix demo release build error

* fix(ios): js context leak when using shared engine

---------

Co-authored-by: OpenHippy <[email protected]>
wwwcg added a commit to wwwcg/Hippy that referenced this pull request Sep 26, 2023
@wwwcg @open-hippy
fix(ios): fix context leak when using shared engine (Tencent#3451)
4523d1c 
* chore(ios): fix demo release build error

* fix(ios): js context leak when using shared engine

---------

Co-authored-by: OpenHippy <[email protected]>
zealotchen0 pushed a commit that referenced this pull request Oct 27, 2023
@wwwcg @open-hippy @zealotchen0
fix(ios): fix context leak when using shared engine (#3451)
66d516b 
* chore(ios): fix demo release build error

* fix(ios): js context leak when using shared engine

---------

Co-authored-by: OpenHippy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozonelmy ozonelmy ozonelmy approved these changes

Assignees
No one assigned
Labels
doc: example framework: ios size: s Denotes a PR that changes 10-99 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wwwcg @ozonelmy @zealotchen0 @open-hippy