Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain major/minor tags #49

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Maintain major/minor tags #49

merged 2 commits into from
Jul 30, 2023

Conversation

anton-yurchenko
Copy link
Contributor

Hello @Templum,
This change will automatically maintain the vX and vX.X tags on every release. It should allow users to lock to a major version and update the workflows less frequently:

name: My Workflow
on: [push, pull_request]
jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: Templum/govulncheck-action@v1

In addition to that, the release flow will force a semantic version tag and not any tag that start with v letter.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6dcc1fe) 98.02% compared to head (d7fecd4) 98.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files           3        3           
  Lines         253      253           
=======================================
  Hits          248      248           
  Misses          4        4           
  Partials        1        1           
Flag Coverage Δ
unit-tests 98.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Templum
Copy link
Owner

Templum commented Jul 29, 2023

@anton-yurchenko thanks for your contribution, it makes sense to me. But I see an issue with your current setup.

It would also create multiple releases, where you probably just want that "one" release. And have those additional tags on the side. As the action will trigger the pipeline again on it's first run.

@anton-yurchenko
Copy link
Contributor Author

anton-yurchenko commented Jul 29, 2023

The pipeline trigger is v[0-9]+.[0-9]+.[0-9]+ which must match only a full semantic version (without metadata, like -beta and such), for example v1.2.3.
This workflow execution will update v1 and v1.2 tags, which won't trigger the pipeline again as they aren't full semantic versions.

P.S: updated integrations pipeline to be triggered only once on fully qualified version tag

@Templum Templum merged commit b6f7f55 into Templum:main Jul 30, 2023
@anton-yurchenko
Copy link
Contributor Author

@Templum can you please create v1 and v1.0 tags manually pointing to the v1.0.0 commit (6bb063b) so we can lock to the current major version?

@Templum
Copy link
Owner

Templum commented Jul 31, 2023

@anton-yurchenko sure thing, will do it as soon as I find the time. I will notify you here, once it is done

@Templum
Copy link
Owner

Templum commented Jul 31, 2023

@anton-yurchenko both are now available:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants