✨ 🐛 Reading Go Runtime Details from GOENV #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid reading the runtime information of the compiled code vs the real one used by govulncheck
Codecov ReportBase: 97.01% // Head: 97.32% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 97.01% 97.32% +0.30%
==========================================
Files 2 3 +1
Lines 201 224 +23
==========================================
+ Hits 195 218 +23
Misses 5 5
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Templum
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within my Dockerfile I use the builder pattern, ensuring the action itself is compiled with a golang version I control. The version chosen by the user of the action will be installed in the runtime part of the container, into which I also install the vulncheck cli. Meaning the CLI is run in the correct env, just the output is incorrect. In fix/16 I switched to reading the go env. This contains the actual runtime information that is relevant to govulncheck.