Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow skipping Sarif Upload #13

Merged
merged 5 commits into from
Nov 6, 2022
Merged

✨ Allow skipping Sarif Upload #13

merged 5 commits into from
Nov 6, 2022

Conversation

Templum
Copy link
Owner

@Templum Templum commented Nov 1, 2022

This PR implements feature request #10 by offering a new input called skip-upload. By default, this will be false, but it can be set to true.

If set to true it will skip the upload and instead write to a file, which then can be consumed or shared with other actions. To highlight this I added a new Example Workflow that uses the upload-artifact-action to upload the file.

@Templum Templum linked an issue Nov 1, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Base: 97.87% // Head: 97.87% // No change to project coverage 👍

Coverage data is based on head (4d0bdb7) compared to base (40992ab).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #13   +/-   ##
=======================================
  Coverage   97.87%   97.87%           
=======================================
  Files           3        3           
  Lines         235      235           
=======================================
  Hits          230      230           
  Misses          4        4           
  Partials        1        1           
Flag Coverage Δ
unit-tests 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Templum
Copy link
Owner Author

Templum commented Nov 1, 2022

Verified behaviour

image

@Templum Templum merged commit c75372f into main Nov 6, 2022
@Templum Templum deleted the feature/10 branch November 6, 2022 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to opt-out from SARIF Report Upload
2 participants