Refactor: Performance tune for OASIS service #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f QueryResult issue: #348
CodeBear801
added
the
Refactor
wangyoucao577
approved these changes
May 28, 2020
| @@ -3,6 +3,7 @@ package connectivitymap | |||
| import ( | |||
| "sync" | |||
|
|
|||
| "github.com/Telenav/osrm-backend/integration/service/oasis/internal/common" | |||
There was a problem hiding this comment.
Will change it to domain/entity :)
| func (q *querier) NearByStationQuery(placeID common.PlaceID) []*common.RankedPlaceInfo { | ||
| if results, ok := q.id2QueryResults[placeID]; ok { | ||
| return results | ||
| } else { |
There was a problem hiding this comment.
Yes. Remove not necessary else.
| @@ -31,36 +31,33 @@ func NewStationGraph(currEnergyLevel, maxEnergyLevel float64, strategy chargings | |||
| func (sg *stationGraph) setStartAndEndForGraph(currEnergyLevel, maxEnergyLevel float64) bool { | |||
| startLocation := sg.querier.GetLocation(stationfindertype.OrigLocationID) | |||
| if startLocation == nil { | |||
| glog.Errorf("Failed to find %#v from Querier GetLocation()\n", stationfindertype.OrigLocationID) | |||
| glog.Errorf("Failed to find %#v from Querier GetLocation()\n", stationfindertype.OrigLocationID.String()) | |||
There was a problem hiding this comment.
Use %s instead, then you don't need to explicitly call String().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Targeting issue: the issue will be CLOSED once the PR merged. If there is no issue that addresses the problem, please open a corresponding issue and link it here. Uses the Closes keyword to close them automatically.
Closes Profile OASIS service for charge station based routing - Round 1 #345, Closes Profile OASIS service for charge station based routing - Round 2 #349
Any other related issue? Mention them here.
Description
This pull improves performance for OASIS service for about 10 times. For more details please go to #345 and #349.
During performance tune and refactoring, I noticed there are some further work to be done:
common, which is not following Telenav's behavior :)Tasklist
LuachangesPre-requirements