Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use nav.Location to replace Location, change point to place #341

Merged
merged 2 commits into from
May 14, 2020
Merged

refactor: use nav.Location to replace Location, change point to place #341

merged 2 commits into from
May 14, 2020

Conversation

CodeBear801
Copy link

@CodeBear801 CodeBear801 commented May 13, 2020 •
edited
Loading

issue: #340

Issue

Description

Refactor package of spatialindex in OASIS service

  • replace Location in spatialindexer to nav.Location
  • replace all name related with point to place

Tasklist

Prerequirements

  • Want to contribute? Great! First, please read this page Contribution Guidelines.
  • If your PR is still work in progress please attach the relevant label.

@CodeBear801 CodeBear801 added the Refactor Rewrite existing code in order to improve its readability, reusability or structure label May 13, 2020
@CodeBear801 CodeBear801 added this to the v10.4.0 milestone May 13, 2020
@CodeBear801 CodeBear801 self-assigned this May 13, 2020
@CodeBear801 CodeBear801 merged commit e783394 into master May 14, 2020
@CodeBear801 CodeBear801 deleted the feature/refactor-oasis branch May 14, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyoucao577 wangyoucao577 wangyoucao577 approved these changes

@hellotechx hellotechx Awaiting requested review from hellotechx

Assignees

@CodeBear801 CodeBear801

Labels
Refactor Rewrite existing code in order to improve its readability, reusability or structure
Projects
None yet
Milestone
v10.4.0
Development

Successfully merging this pull request may close these issues.

Refactor package spatialindex in OASIS service
2 participants
@CodeBear801 @wangyoucao577