refactor: change edgeIDAndData to edge and replace location defin…
#307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ition with nav.Location issue: #282
CodeBear801
added
the
Refactor
| edgeId edgeID | ||
| edgeData *edge | ||
| edgeData *edgeMetric |
There was a problem hiding this comment.
edgeMetric *edgeMetric, or just simply *edgeMetric
CHANGELOG-FORK.md
Outdated
| @@ -4,6 +4,7 @@ Changes from v10.2.0 | |||
| - Feature: | |||
| - ADDED **HTTP API** `annotation/ways` in OSRM route response after `osrm-ranking` process(retrieve `annotation/ways` from `annotation/nodes`) [#296](https://github.com/Telenav/osrm-backend/pull/296) | |||
| - CHANGED for internal refactoring, moved `unidbpatch` and `mapsource` packages into `integration/util` folder [#300](https://github.com/Telenav/osrm-backend/pull/300) | |||
| - CHANGED for internal refactoring, refactor staiongraph to isolate algorithm, data structure and topological [#302] | |||
There was a problem hiding this comment.
Would you please append the link so that the #302 can be clickable? Meanwhile, this entry is only for the last PR, could you please also add one for this PR? Or maybe append also this PR's ID, i.e. one entry for both PR since this PR is the only supplement for the former one.
Furthermore, staiongraph -> stationgraph?
wangyoucao577
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ition with nav.Location
Issue
Resolves #282
Description
edgeIDAndDatatoedgelocationInfotonav.LocationTasklist