refactor: refactor station graph to isolate algorithm, data structure and topological #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBear801
added
the
Refactor
issue: #282
|
Will read it later. Please follow the PR template and always add entry in CHANGELOG-FORK.md. The rules in https://github.com/Telenav/osrm-backend/wiki/CHANGELOG. |
wangyoucao577
approved these changes
Apr 23, 2020
| duration float64 | ||
| } | ||
|
|
||
| type edgeIDAndData struct { |
There was a problem hiding this comment.
I'll prefer to name it edge. Name the the former edge to metric or something like this.
There was a problem hiding this comment.
Good suggestion. Will consider to make the change in the next pull.
| func (nc *nodeContainer) getNode(id nodeID) *node { | ||
| if n, ok := nc.id2NodePtr[id]; ok { | ||
| return n | ||
| } else { |
There was a problem hiding this comment.
Prefer to remove the else. See https://github.com/golang/go/wiki/CodeReviewComments#indent-error-flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#282
Description
Remove
neighborinnode, keep connectivity information insidegraphAbstract the layer of interface
Graph, make algorithm such asDijkstradepends on interface onlyAbstract the layer of
connectivitymap.Querier, which hides the logic for how connectivity is been builtsearch along route charge station query, user just pass in the connectivity graph of charge stations between low energy pointcharge station based routing, user just pass in the pre-built connectivity graph between each charge stationsRemove logic of building graph in
stationgraph, put them inside ofnode_graph. All connectivity is build on the fly, not like previous version,stationgraphbabysits the creation of graph. The responsibility ofstationgraphnow is calling internal functions to do the work and convert result to certain format.More information could be found here:
osrm-backend/integration/service/oasis/stationgraph/doc.go
Line 1 in 9022026
To to:
connectivitymap.Queriertoconnectivitymap.TopoQuerier, still consideringlocationinfo, usenav.locationinternalTasklist