Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Implement function of GenerateChargeSolutions for station_graph #215

Merged
merged 15 commits into from
Mar 13, 2020

Conversation

CodeBear801
Copy link

@CodeBear801 CodeBear801 commented Mar 10, 2020

Issue

#143

  • This pull need feat: Implement function to calcualte charge cost #204 to be merged first.
  • After stationGraph is construct, it could call algorithm in graph to calculate best solution and generate result in solution format
  • Record location information on node
  • Fix bug in stationGraph during constructing graph, which has expectation in node sequence
  • Make unit test work with Dijkstra especially for arrival energy/charging time part. (More unit test will be added later.)

Tasklist

  • add function of GenerateChargeSolutions
  • add tests
  • review

@CodeBear801 CodeBear801 added the Prototype Proof of concept label Mar 10, 2020
@wangyoucao577
Copy link

This PR is too hard to review since most of the changes are same as PR #204. It's too difficult to distinguish the real changes. Would you please merge #204 then rebase master? After that we'll be able to review it easier.

@CodeBear801
Copy link
Author

CodeBear801 commented Mar 11, 2020

This PR is too hard to review since most of the changes are same as PR #204. It's too difficult to distinguish the real changes. Would you please merge #204 then rebase master? After that we'll be able to review it easier.

Sure, working on that.

@wangyoucao577
Copy link

One more thing: it's better to always use rebase instead of merge, which can avoid strange commit like "@CodeBear801
Merge branch 'feature/oasis-integration2-patch5' of https://github.co…
c21093d
…m/Telenav/osrm-backend into feature/oasis-integration2-patch5"

@CodeBear801 CodeBear801 mentioned this pull request Mar 12, 2020
9 tasks
@CodeBear801 CodeBear801 reopened this Mar 12, 2020
@CodeBear801 CodeBear801 merged commit 6a5433b into master Mar 13, 2020
@CodeBear801 CodeBear801 deleted the feature/oasis-integration2-patch5 branch March 13, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prototype Proof of concept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants