correct comments for "compress edge if it crosses a traffic signal" #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBear801
reviewed
Mar 10, 2020
src/extractor/graph_compressor.cpp
Outdated
| // traffic signals in the `traffic signal` list, which EdgeData | ||
| // doesn't have access to. | ||
| */ | ||
| // add node penalty when compress edge if it crosses a traffic signal. |
There was a problem hiding this comment.
How about
// Add node penalty when compress edge crosses a traffic signal
|
Some proof of this PR: I try to add a debug log at here like this: if (has_node_penalty)
{
util::Log(logDEBUG) << "node: " << node_v << " has traffic_signal when compress.";
// we cannot handle this as node penalty, if it depends on turn direction
if (fwd_edge_data1.flags.restricted != fwd_edge_data2.flags.restricted)
continue;Then I got some logs when I compile the latest nevada.osm.pbf: [debug] node: 16454 has traffic_signal when compress.
[debug] node: 48093 has traffic_signal when compress.
[debug] node: 71512 has traffic_signal when compress.
[debug] node: 82989 has traffic_signal when compress.
[debug] node: 115384 has traffic_signal when compress.
...I check several of them in compiled $ osrm-files-extractor -alsologtostderr -f nevada-latest.osrm.cnbg -summary 2
I0311 12:30:04.623195 27125 contents.go:41] Loaded from nevada-latest.osrm.cnbg
I0311 12:30:04.624706 27125 contents.go:42] OSRN v5.22.0
I0311 12:30:04.624754 27125 contents.go:44] compressed node based graph meta 746678 count 746678
I0311 12:30:04.624779 27125 contents.go:46] CompressedNodeBasedGraphEdges[0] {Source:15 Target:724080}
I0311 12:30:04.624831 27125 contents.go:46] CompressedNodeBasedGraphEdges[1] {Source:15 Target:589125}
$
$ osrm-files-extractor -alsologtostderr -f nevada-latest.osrm.cnbg -summary 746678 2>&1 | grep ":16454" |
CodeBear801
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.
Closes #198
Please read our documentation on release and version management.
If your PR is still work in progress please attach the relevant label.
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?
This PR is cherry-pick from Project-OSRM#5384 which don't know when can be merged.