Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/observe dot timestamp #138

Merged
merged 3 commits into from
Jan 23, 2020

Conversation

wangyoucao577
Copy link

@wangyoucao577 wangyoucao577 commented Jan 21, 2020

Issue

What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.
#122

Please read our documentation on release and version management.
If your PR is still work in progress please attach the relevant label.

Tasklist

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

doc: https://github.com/Telenav/open-source-spec/blob/master/osrm/doc/osrm-toolchain-files/map.osrm.timestamp.md

@wangyoucao577 wangyoucao577 added this to the Sprint 58(Dev:02/04) milestone Jan 21, 2020
@wangyoucao577 wangyoucao577 added Research Read paper/issue/code for better understanding and removed Implementation labels Jan 21, 2020
@CodeBear801
Copy link

Just some discussion for osrm-extractor

  • Each osrm suffix will implement a content file, and inside of them will implement interface from ContentsOperator
  • Inside each xxx/content.go, it will define data schema for the contents inside of which.
  • Important logic is here _, err := io.Copy(writer, tr);, by writer from each element, we deserialized data object.

@wangyoucao577
Copy link
Author

Just some discussion for osrm-extractor

  • Each osrm suffix will implement a content file, and inside of them will implement interface from ContentsOperator
  • Inside each xxx/content.go, it will define data schema for the contents inside of which.
  • Important logic is here _, err := io.Copy(writer, tr);, by writer from each element, we deserialized data object.

Yes!

@wangyoucao577 wangyoucao577 merged commit 037a545 into master-telenav Jan 23, 2020
@wangyoucao577 wangyoucao577 deleted the feature/observe-dot-timestamp branch January 23, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prototype Proof of concept Research Read paper/issue/code for better understanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants