update oasis api #136
Merged
update oasis api #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only support nearest charge station search for now. issues: #132
- Remove "Location field", add "Address" field which contains geo_coordinates + a list of nav_coordinates
- Add field of detail_url, external user could retrieve all information related with specific charge station
- Add field of estimate remaining range for each solution
issue: #132 (comment)
#128
|
This PR depends on the previous one #135. Will you please either remove the duplicated changes or rebase until the previous PR merged? |
|
Yes, not expect to review now, I add no reviewers :). I will rebase until that one is merged. |
wangyoucao577
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#132
#128
Tasklist
Requirements / Relations
#132 (comment)