Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move solution, osrmhelper and searchhelper into oasis/internal #342

Closed
CodeBear801 opened this issue May 14, 2020 · 1 comment · Fixed by #343
Closed

Move solution, osrmhelper and searchhelper into oasis/internal #342

CodeBear801 opened this issue May 14, 2020 · 1 comment · Fixed by #343
Assignees
Labels
Refactor Rewrite existing code in order to improve its readability, reusability or structure
Milestone

Comments

@CodeBear801
Copy link

Description:
These package is not expect to be called by external users, move them into internal and hide for external calls other than oasis package.

@CodeBear801
Copy link
Author

Remove package of haversine, use bleve/geo instead.

@CodeBear801 CodeBear801 self-assigned this May 14, 2020
@CodeBear801 CodeBear801 added the Refactor Rewrite existing code in order to improve its readability, reusability or structure label May 14, 2020
@CodeBear801 CodeBear801 added this to the v10.5.0 milestone May 14, 2020
CodeBear801 added a commit that referenced this issue May 14, 2020
@wangyoucao577 wangyoucao577 modified the milestones: v10.5.0, v10.4.0 May 15, 2020
CodeBear801 added a commit that referenced this issue May 15, 2020
…r into oasis/internal (#343)

* refactor: move solution, osrmhelper and searchhelper into oasis/internal
issue: #342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Rewrite existing code in order to improve its readability, reusability or structure
Projects
None yet
2 participants