Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken listener chain due to inheritance from mixin and base component #86

Closed
jonathanl-telenav opened this issue Nov 4, 2021 · 1 comment
Closed

Broken listener chain due to inheritance from mixin and base component #86

jonathanl-telenav opened this issue Nov 4, 2021 · 1 comment
Assignees
@jonathanl-telenav
Labels
bug Something isn't working
Milestone
1.1.1

Comments

@jonathanl-telenav
Copy link
Contributor

Description
The ResourceTrait class should inherit from Repeater and not RepeaterMixin so that classes extending BaseComponent that use ResourceTrait don't have two repeater implementations at the same time.

Code was added to BaseRepeater to flag components that incorrectly use a RepeaterMixin as well. This turned up several other places in the code where invalid repeater mixins were removed.
@jonathanl-telenav jonathanl-telenav added the bug Something isn't working label Nov 4, 2021
@jonathanl-telenav jonathanl-telenav added this to the 1.1 milestone Nov 4, 2021
@jonathanl-telenav jonathanl-telenav self-assigned this Nov 4, 2021
jonathanl-telenav pushed a commit to Telenav/kivakit-extensions that referenced this issue Nov 4, 2021
@jonathanlocke
👷 Fix snapshot build on develop branch
a555362 
 - Fix mesakit-clean-sparkling.sh call to remove_maven_repository
 - Fix File.relativeTo() method
 - Fix broken listener chain due to inheritance from mixin and base component (Telenav/kivakit#86)
jonathanl-telenav pushed a commit to Telenav/lexakai that referenced this issue Nov 4, 2021
@jonathanlocke
👷 Fix snapshot build on develop branch
cea9fc3 
 - Fix mesakit-clean-sparkling.sh call to remove_maven_repository
 - Fix File.relativeTo() method
 - Fix broken listener chain due to inheritance from mixin and base component (Telenav/kivakit#86)
jonathanl-telenav pushed a commit that referenced this issue Nov 4, 2021
@jonathanlocke
👷 Fix snapshot build on develop branch
55bb0c7 
 - Fix mesakit-clean-sparkling.sh call to remove_maven_repository
 - Fix File.relativeTo() method
 - Fix broken listener chain due to inheritance from mixin and base component (#86)
jonathanl-telenav pushed a commit to Telenav/mesakit that referenced this issue Nov 4, 2021
@jonathanlocke
👷 Fix snapshot build on develop branch
00a1587 
 - Fix mesakit-clean-sparkling.sh call to remove_maven_repository
 - Fix File.relativeTo() method
 - Fix broken listener chain due to inheritance from mixin and base component (Telenav/kivakit#86)
@jonathanl-telenav jonathanl-telenav modified the milestones: 1.1, 1.1.1 Nov 5, 2021
jonathanl-telenav pushed a commit to Telenav/kivakit-extensions that referenced this issue Nov 5, 2021
@jonathanlocke
👷 Fix snapshot build on develop branch
8bb8fde 
 - Fix mesakit-clean-sparkling.sh call to remove_maven_repository
 - Fix File.relativeTo() method
 - Fix broken listener chain due to inheritance from mixin and base component (Telenav/kivakit#86)
  - Add .proto file output (Telenav/kivakit#89)
jonathanl-telenav pushed a commit that referenced this issue Nov 5, 2021
@jonathanlocke
👷 Fix snapshot build on develop branch
8f5f5d3 
 - Fix mesakit-clean-sparkling.sh call to remove_maven_repository
 - Fix File.relativeTo() method
 - Fix broken listener chain due to inheritance from mixin and base component (#86)
  - Add .proto file output (#89)
@jonathanl-telenav
Copy link
Contributor Author

Fixed in 1.1.1-SNAPSHOT, will merge to 1.1.0 release

jonathanl-telenav pushed a commit to Telenav/kivakit-assets that referenced this issue Nov 5, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
cd1669b 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/cactus that referenced this issue Nov 5, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
3a055b1 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/lexakai that referenced this issue Nov 5, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
bc27591 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/lexakai-annotations that referenced this issue Nov 5, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
4f64d08 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit that referenced this issue Nov 5, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
bc7e030 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](#89)

### fixed

  * [Division microservice example is broken #87](#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](#88)
jonathanl-telenav pushed a commit to Telenav/kivakit-examples that referenced this issue Nov 5, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
0d01099 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/kivakit-extensions that referenced this issue Nov 5, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
b09bad9 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/kivakit-extensions that referenced this issue Nov 5, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
985194f 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/lexakai-annotations that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
00ef398 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)
   * Upgraded to (modular) Wicket 9.6
   * Build documentation

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/kivakit-extensions that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
aef4002 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)
   * Upgraded to (modular) Wicket 9.6
   * Build documentation

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/mesakit-extensions that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
edbcddb 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)
   * Upgraded to (modular) Wicket 9.6
   * Build documentation

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/mesakit-examples that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
d0fc0f0 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)
   * Upgraded to (modular) Wicket 9.6
   * Build documentation

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/kivakit-examples that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
815b70b 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)
   * Upgraded to (modular) Wicket 9.6
   * Build documentation

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/kivakit-assets that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
f120479 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)
   * Upgraded to (modular) Wicket 9.6
   * Build documentation

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/cactus that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
90ee4f0 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)
   * Upgraded to (modular) Wicket 9.6
   * Build documentation

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
616dfc6 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](#89)
   * Upgraded to (modular) Wicket 9.6
   * Build documentation

### fixed

  * [Division microservice example is broken #87](#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](#88)
jonathanl-telenav pushed a commit to Telenav/mesakit that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
806fe60 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/mesakit that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
d7dab4b 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)
   * Upgraded to (modular) Wicket 9.6
   * Build documentation

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/kivakit-extensions that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
536ec3c 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)
   * Upgraded to (modular) Wicket 9.6
   * Build documentation

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit to Telenav/kivakit-assets that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
a68f249 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](Telenav/kivakit#89)
   * Upgraded to (modular) Wicket 9.6
   * Build documentation

### fixed

  * [Division microservice example is broken #87](Telenav/kivakit#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](Telenav/kivakit#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](Telenav/kivakit#88)
jonathanl-telenav pushed a commit that referenced this issue Nov 6, 2021
@jonathanlocke
👷 Prepare for 1.1.1 release
523419f 
### added

   * [Add .proto output files to kivakit-microservice GRPC service](#89)
   * Upgraded to (modular) Wicket 9.6
   * Build documentation

### fixed

  * [Division microservice example is broken #87](#87)
  * [Broken listener chain due to inheritance from mixin and base component #86](#86)
  * [Documentation links are broken in kivakit 1.1.0 #88](#88)
@jonathanl-telenav jonathanl-telenav moved this to Done in KivaKit Jan 4, 2022
jonathanl-telenav added a commit that referenced this issue Aug 5, 2022
@jonathanl-telenav
Feature/for parking incidents, the response is different from swagger…
ec90e0c 
… definition #86 and narrow logging (#129)

* 📝 fix error handling
 - HttpStatus -> enum
 - HttpProblem extends Problem, adds HttpStatus
 - HttpNetworkLocation.content() takes Listener
 - Rewire Result message capturing
 - MicroservletResponse.prepareResponse() -> onPrepareResponse()
 - Remove problemWithCode()
 - Wire response so request response-type parameter is always-okay|http-status (always-okay is default for now) to allow flexible responses. always-okay returns error messages inside an HTTP 200 response. http-status returns different HTTP error codes depending on the response, and separates the content from error responses. content is returned with 200 responses, errors are returned with >= 300 responses.

* 👷 update invalid build-branch.yml patterns

* 🐛 fix result listening issue

* 📝 editing

* 🍱 add interface composition diagram

* 🎨 format interfaces

* 🍱 add interface-composition diagram

* Explicitly use a branch with debug logging - should trigger a new run

* Switch back to using the main branch so the debug-log workflow change doesn't inadvertently get merged

* Trivial commit to force a PR build

Co-authored-by: Tim Boudreau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanl-telenav jonathanl-telenav

Labels
bug Something isn't working
Projects
KivaKit
Status: Done
Milestone
1.1.1
Development

No branches or pull requests
1 participant
@jonathanl-telenav