Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OSLog when available instead of print #133

Closed
wants to merge 1 commit into from
Closed

Use OSLog when available instead of print #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Sources/TelemetryClient/LogHandler.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import Foundation
import OSLog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@easydev991 Don't you need to make sure that this can be imported before importing it? I imagine building on systems without access to OSLog would make the code fail.


public struct LogHandler {
public enum LogLevel: Int, CustomStringConvertible {
Expand Down Expand Up @@ -29,7 +30,16 @@ public struct LogHandler {

public static var stdout = { logLevel in
LogHandler(logLevel: logLevel) { level, message in
print("[TelemetryDeck: \(level.description)] \(message)")
if #available(macOS 11.0, *) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The availability check here only checks for macOS, but this lib supports other platforms as well. Those should be checked, too. Consider also Linux/Windows platforms.

let logger = Logger(subsystem: "TelemetryDeck", category: "LogHandler")
switch level {
case .debug: logger.debug("\(message)")
case .info: logger.info("\(message)")
case .error: logger.error("\(message)")
}
} else {
print("[TelemetryDeck: \(level.description)] \(message)")
}
}
}
}