fix type definition #121
Merged
fix type definition #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue TehShrike#120 remove default export
TehShrike
added a commit
that referenced
this pull request
Oct 3, 2018
This actually executes the typescript test file to make sure that the function actually gets imported and can be evaluated by TypeScript without throwing an error. Should be fixed by #121
|
I don't see how this is a fix. How is import * as merge from 'deepmerge';better than import merge from 'deepmerge';I get that there's room for personal taste (personally, I find |
|
@msssk it is not a matter of taste, See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import#Description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #120
remove default export