Check if at location previously without using Overpass #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
- Coverage 46.32% 46.24% -0.09%
==========================================
Files 98 98
Lines 1660 1663 +3
Branches 68 68
==========================================
Hits 769 769
- Misses 866 869 +3
Partials 25 25
Continue to review full report at Codecov.
|
Teester
force-pushed
the
whats-nearby-16
branch
from
22514ab to
e3dbcd6
Compare
Teester
force-pushed
the
whats-nearby-16
branch
from
4755dfd to
3a8ba74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #16: When location is checked, we compare the distance from the current location to nearby POIs stored in the database. If they are within 20m of a location that they've been to in the past week, we don't query Overpass.