Fix FromMeta for chars #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Veetaha
approved these changes
Apr 7, 2021
Co-authored-by: Veetaha <[email protected]>
|
Thanks! Glad you are enjoying the library. I'll ship an update with this now. |
|
v0.12.3 is live with this change. |
|
Nice, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
Yesterday I spent all evening figuring out why my proc macro cannot recognize char attributes after I redefined FromMeta::from_char for my newtype. Here is the fix for the issue. I also add FromMeta impl for char as I don't see any reason why darling doesn't support chars out of the box.
Nice lib, btw))