impl From<syn::Error> for Error #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`syn` provides useful functions for low-level AST parsing that go beyond what `darling` attempts to support natively. In these cases, a caller may want to propagate a `syn::Error` up through a function that returns a `darling::Result`. This new impl guarantees lossless handling, emitting the same compiler error is emitted as if the `syn::Error::to_compile_error` had been called directly.
TedDriggs
force-pushed
the
from-syn-error
branch
from
9ef676e to
6e38c37
Compare
|
Merging before CI completion after local testing against 1.31.0 and stable without issue. Filed #117 to address the unacceptable slowness of Travis-CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synprovides useful functions for low-level AST parsing that go beyondwhat
darlingattempts to support natively. In these cases, a callermay want to propagate a
syn::Errorup through a function that returnsa
darling::Result.This new impl guarantees lossless handling, emitting the same compiler
error is emitted as if the
syn::Error::to_compile_errorhad beencalled directly.