Report errors on unsupported attributes #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jonasbb does the error put the span in the right place? The tests in this repo don't have a good way to show me where the span is referencing, which is unfortunate. |
TedDriggs
commented
Jan 4, 2021
|
@TedDriggs Yes, the span looks right |
TedDriggs
force-pushed
the
unsupported-attributes
branch
2 times, most recently
from
6a475d0 to
cc978c0
Compare
`darling` pre-dates Rust support for non-meta attributes. These increase flexibility for Rust code, but mean that not `darling` does not parse all valid attributes. `darling` previously ignored these outright, creating misleading errors, such as claiming all fields were missing. This commit makes unsupported attributes explicit errors. To allow for detailed diagnostic information in the future without changing the crate's public API, the parsing of `Attribute` into `MetaList` is handled in a new function that wraps `syn`'s own `parse_meta`. This commit uses that structure to include an attribute path in an example for the name-value error case; future commits could expand that function to identify places where the caller may have missed quotation marks, for example. Fixes #96
TedDriggs
force-pushed
the
unsupported-attributes
branch
from
cc978c0 to
8f4bb9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
darlingpre-dates Rust support for non-meta attributes.These increase flexibility for Rust code, but mean that not
darlingdoes not parse all valid attributes.
darlingpreviously ignored these outright, creating misleading errors.This commit makes those explicit errors.
Fixes #96