Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update Python 3 version in v11 and v12" #310

Merged
merged 1 commit into from
May 27, 2020
Merged

Revert "Update Python 3 version in v11 and v12" #310

merged 1 commit into from
May 27, 2020

Conversation

yajo
Copy link
Contributor

@yajo yajo commented May 27, 2020

This reverts commit dbaaa27 from #290.

Also reverts v13 to oldest supported python version (3.6 per the docs).

@Tecnativa TT23435

@yajo yajo self-assigned this May 27, 2020
@yajo yajo added the bug label May 27, 2020
This reverts commit dbaaa27 from #290.

Also reverts v13 to oldest supported python version (3.6 per the docs).

I had to change $PIP_NO_CACHE_DIR in v13. See pypa/pip#5735.

@Tecnativa TT23435
@yajo yajo merged commit ab9c74d into master May 27, 2020
@yajo yajo deleted the olderpy branch May 27, 2020 12:09
@JordiBForgeFlow
Copy link

@yajo is there any particular reason not revert to 3.6? We face some bugs with 3.5 that are fixed in 3.6

@pedrobaeza
Copy link
Member

Which bugs? The official Python version for v11 and v12 is P3.5.

@yajo
Copy link
Contributor Author

yajo commented Jun 11, 2020

The reason is that we chose to stick to the minimal supported version as stated officially, believing that it will be most supported.

FTR v13 was reverted to 3.6 for this same reason.

Another possibility would have been to update gevent, but that's completely away from the official requirements, and thus we didn't want to enter those grounds.

@JordiBForgeFlow
Copy link

Ok. They are very project specific issues, and we fixed assuming 3.7. So no problem. We'll revert to using a 3.5 compatible fix.

@pedrobaeza
Copy link
Member

pedrobaeza commented Jun 11, 2020

Is it worth to share that specific fixes?

Sorry anyway for changing this, but there's a problem with gevent + Odoo that we faced it using upper versions (specially 3.7).

@JordiBForgeFlow
Copy link

Not worth. These are scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants