chore: updated to HAproxy 3.0 and forced running as root #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems correct. @yajo do you see it good for being merged? |
yajo
approved these changes
Jul 9, 2024
|
@josep-tecnativa please check the error in the CI: https://github.com/Tecnativa/docker-socket-proxy/actions/runs/9854039033/job/27205922038 |
jamesdkelly88
referenced
this pull request
in jamesdkelly88/db-lab
Sep 4, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/tecnativa/docker-socket-proxy](https://redirect.github.com/Tecnativa/docker-socket-proxy) | minor | `0.1.2` -> `0.2.0` | --- ### Release Notes <details> <summary>Tecnativa/docker-socket-proxy (ghcr.io/tecnativa/docker-socket-proxy)</summary> ### [`v0.2.0`](https://redirect.github.com/Tecnativa/docker-socket-proxy/releases/tag/v0.2.0) [Compare Source](https://redirect.github.com/Tecnativa/docker-socket-proxy/compare/v0.1.2...v0.2.0) #### What's Changed - chore: updated to HAproxy 3.0 and forced running as root by [@​proudier](https://redirect.github.com/proudier) in [https://github.com/Tecnativa/docker-socket-proxy/pull/130](https://redirect.github.com/Tecnativa/docker-socket-proxy/pull/130) #### New Contributors - [@​proudier](https://redirect.github.com/proudier) made their first contribution in [https://github.com/Tecnativa/docker-socket-proxy/pull/130](https://redirect.github.com/Tecnativa/docker-socket-proxy/pull/130) **Full Changelog**: Tecnativa/docker-socket-proxy@v0.1.2...v0.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/jamesdkelly88/db-lab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This MR bumps haproxy to v3.0 and force it to run as root.
Discussion
Starting with haproxy 2.4, the official/upstream docker image runs with a haproxy user, instead of root (code).
While this is an improvement of their security posture, it's unenviable in the context of docker-socket-proxy. Indeed, haproxy needs to access the docker socket file, which is bound from the host where it belongs to
root:dockeron a default docker deployment (ie. not rootless).My take is that docker-socket-proxy should work out of the box with the default docker configuration. And because this MR doesn't deteriorate the current security posture of this project, im submitting it as is.
Tests
Successfully ran locally all the test I could find
poetry run pytest --prebuildpre-commit run --all