Added DockerCredentialExecutor to handle login and logout from docker… #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jocobtt
approved these changes
Mar 4, 2024
JeffreyRoss
reviewed
Mar 4, 2024
| private boolean usePlainTextPassword; | ||
| private boolean dryRun; | ||
|
|
||
| public DockerCredentialExecutor(Settings settings, String repoId, String repoUrl, File dockerContext, boolean usePlainTextPassword, boolean dryRun) { |
There was a problem hiding this comment.
A: The logic here seems very similar to the AbstractDockerMojo class, can you help me understand what drives the need for a specialized class to handle these functions?
There was a problem hiding this comment.
It is actually the same logic, I forgot to remove it. Good catch!
jacksondelametter
force-pushed
the
deploy_all_docker
branch
from
3653967 to
8708403
Compare
peter-mcclonski
approved these changes
Mar 4, 2024
cpointe-ibllanos
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… repository