#94 Modifying retrieve caching logic to allow for non-habushu packaging #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -32,6 +32,11 @@ public class RetrieveWheelsMojo extends AbstractHabushuMojo { | |||
| @Parameter(property = "habushu.wheelDependencies", required = false) | |||
| protected List<WheelDependency> wheelDependencies; | |||
|
|
|||
| @Override | |||
| public void execute() throws MojoExecutionException, MojoFailureException { | |||
There was a problem hiding this comment.
A: Probably worth clarifying the logic being skipped in a comment.
There was a problem hiding this comment.
@cpointe-ibllanos added.
cpointe-ibllanos
approved these changes
Mar 5, 2024
ewilkins-csi
approved these changes
Mar 5, 2024
cpointe-ibllanos
added a commit
that referenced
this pull request
Mar 8, 2024
Change output directory for Behave tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the RetrieveWheels functionality requires that the executing packaging is Habushu, however, there are some use cases where we'd want to use these functionality in non-habushu packaging.