Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new cacheWheels:boolean configuration to the habushu-maven-plugin that caches build wheel files. #75

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

JeffreyRoss
Copy link
Collaborator

In order to make mono-repository wheel files more available across multiple modules we want to cache them into a reliable location. This change introduces a new habushu-maven-plugin configuration cacheBuildWheelFiles:boolean

When set to true will copy the build's wheel file into poetry's cache directory
{poetry-cache-dir}/cache/wheels/{artifactId}/*.whl
When set to false nothing will be cached.
Default is false.

Copy link
Contributor

@cpointe-ibllanos cpointe-ibllanos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one small question I'll let someone with more Habushu experience give the approval.

Copy link
Contributor

@georgit georgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

README.md Outdated Show resolved Hide resolved
@JeffreyRoss JeffreyRoss merged commit d4bf767 into dev Dec 27, 2023
1 check passed
@JeffreyRoss JeffreyRoss deleted the #74-add-cacheBuildWheelFiles-config branch December 27, 2023 20:48
@JeffreyRoss JeffreyRoss changed the title Add new cacheBuildWheelFiles:boolean configuration to the habushu-maven-plugin that caches build wheel files. Add new cacheWheels:boolean configuration to the habushu-maven-plugin that caches build wheel files. Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants