-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new cacheWheels:boolean
configuration to the habushu-maven-plugin that caches build wheel files.
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plugin, and updating the README
...u-maven-plugin/src/main/java/org/technologybrewery/habushu/BuildDeploymentArtifactsMojo.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, one small question I'll let someone with more Habushu experience give the approval.
georgit
approved these changes
Dec 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
...u-maven-plugin/src/main/java/org/technologybrewery/habushu/BuildDeploymentArtifactsMojo.java
Outdated
Show resolved
Hide resolved
...u-maven-plugin/src/main/java/org/technologybrewery/habushu/BuildDeploymentArtifactsMojo.java
Outdated
Show resolved
Hide resolved
...u-maven-plugin/src/main/java/org/technologybrewery/habushu/BuildDeploymentArtifactsMojo.java
Show resolved
Hide resolved
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/exec/PoetryCommandHelper.java
Outdated
Show resolved
Hide resolved
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/util/HabushuUtil.java
Outdated
Show resolved
Hide resolved
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/util/HabushuUtil.java
Outdated
Show resolved
Hide resolved
ewilkins-csi
approved these changes
Dec 27, 2023
JeffreyRoss
changed the title
Add new
Add new Dec 28, 2023
cacheBuildWheelFiles:boolean
configuration to the habushu-maven-plugin that caches build wheel files. cacheWheels:boolean
configuration to the habushu-maven-plugin that caches build wheel files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make mono-repository wheel files more available across multiple modules we want to cache them into a reliable location. This change introduces a new habushu-maven-plugin configuration cacheBuildWheelFiles:boolean
When set to true will copy the build's wheel file into poetry's cache directory
{poetry-cache-dir}/cache/wheels/{artifactId}/*.whl
When set to false nothing will be cached.
Default is false.