67 secure install #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-gary
reviewed
Dec 20, 2023
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/PyenvAndPoetrySetup.java
Outdated
Show resolved
Hide resolved
aaron-gary
reviewed
Dec 20, 2023
| password = HabushuUtil.findPasswordForServer(settings, pypiRepoId, decryptPassword); | ||
| } | ||
|
|
||
| if (StringUtils.isNotEmpty(pypiRepoUrl)) { |
There was a problem hiding this comment.
If the pypiRepoUrl is empty, should we log an error or throw and exception? Not sure what the best approach is here.
aaron-gary
reviewed
Dec 20, 2023
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/util/HabushuUtil.java
Show resolved
Hide resolved
aaron-gary
approved these changes
Dec 20, 2023
georgit
force-pushed
the
67-secure-install
branch
from
ff28e20 to
8737561
Compare
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/PyenvAndPoetrySetup.java
Outdated
Show resolved
Hide resolved
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/CleanHabushuMojo.java
Outdated
Show resolved
Hide resolved
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/PyenvAndPoetrySetup.java
Show resolved
Hide resolved
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/PyenvAndPoetrySetup.java
Outdated
Show resolved
Hide resolved
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/PyenvAndPoetrySetup.java
Show resolved
Hide resolved
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/PyenvAndPoetrySetup.java
Outdated
Show resolved
Hide resolved
ewilkins-csi
approved these changes
Dec 21, 2023
georgit
force-pushed
the
67-secure-install
branch
from
779a86c to
1e1cc2a
Compare
georgit
force-pushed
the
67-secure-install
branch
from
1e1cc2a to
9e0efe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to allow Habushu to use maven username/password when pulling dependencies.
Currently, Habushu does not use user credentials when pulling dependencies and instead pulls them anonymously. This is leading to some issues for dependencies that require credentials. We would like to fix this. These credentials are in the settings.xml file in the .m2 directory.
Along the way, we found that the HabushuUtil file was missing the first level of indentation for all methods. After some though, we think the most likely reason for this is a copy/paste error and decided it was worth fixing. Maybe there is some convention of not indenting in a final class in Java, but we didn't think that likely.