Update the Poetry Core version in the Habushu project to the required version #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satishmanda
force-pushed
the
AIOPS-2767
branch
from
297386d to
1ed06be
Compare
| isMajorVersionUpdateRequired = false; | ||
| isMinorVersionUpdateRequired = false; | ||
| // check if we need to upgrade the poetry-core version. | ||
| if(IsPoetrycoreUpgradeRequired(dependency)) { |
There was a problem hiding this comment.
A: Minor, the if statement is unnecessary.
return IsPoetrycoreUpgradeRequired(dependency)
There was a problem hiding this comment.
We are looping through the dependency map and iterate through all the elements to see if we any of it requires the upgrade. We need the if statement here incase any one of them requires upgrade.
.../src/main/java/org/technologybrewery/habushu/migration/CustomPoetrycoreVersionMigration.java
Outdated
Show resolved
Hide resolved
cpointe-ibllanos
approved these changes
Dec 5, 2023
d-ryan-ashcraft
requested changes
Dec 5, 2023
.../src/main/java/org/technologybrewery/habushu/migration/CustomPoetrycoreVersionMigration.java
Show resolved
Hide resolved
.../src/main/java/org/technologybrewery/habushu/migration/CustomPoetrycoreVersionMigration.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/technologybrewery/habushu/migration/CustomPoetrycoreVersionMigration.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/technologybrewery/habushu/migration/CustomPoetrycoreVersionMigration.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/technologybrewery/habushu/migration/CustomPoetrycoreVersionMigration.java
Outdated
Show resolved
Hide resolved
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/util/PoetryUtil.java
Outdated
Show resolved
Hide resolved
satishmanda
force-pushed
the
AIOPS-2767
branch
from
1ed06be to
248a384
Compare
satishmanda
changed the title
satishmanda
force-pushed
the
AIOPS-2767
branch
from
248a384 to
d5ef6b1
Compare
satishmanda
force-pushed
the
AIOPS-2767
branch
from
d5ef6b1 to
433ad94
Compare
d-ryan-ashcraft
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIOPS-2767 Added functionality to upgrade the poetry-core version required by the Habushu