#47 🥅 catch pyenv vs. system python configuration mismatch #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-ryan-ashcraft
commented
Sep 7, 2023
| @@ -139,7 +139,7 @@ public void execute() throws MojoExecutionException, MojoFailureException { | |||
| } | |||
|
|
|||
| if (!missingRequiredToolMsgs.isEmpty()) { | |||
There was a problem hiding this comment.
I (Informational): just making it easier to read the error
| @@ -191,6 +191,17 @@ private String validatateAndConfigurePyenv(List<String> missingRequiredToolMsgs, | |||
| currentPythonVersion = pyenvHelper.getCurrentPythonVersion(); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I: this is the meat of the change - when pyenv isn't configured correctly but we have configured habushu to use it, pyenv says your python version is one thing, but python calls on the path say another.
| @@ -21,17 +22,17 @@ public class PythonVersionHelper { | |||
|
|
|||
| private static final String PYTHON_COMMAND = "python"; | |||
| private static final String PYTHON_3_COMMAND = "python3"; | |||
There was a problem hiding this comment.
I: some minor sonarlint tidying while I was here - this class is easier to review if you hide whitespace
| } | ||
|
|
||
| /** | ||
| * Executes a python command with the given arguments, logs the executed | ||
| * command, and returns the resultant process output as a string. | ||
| * at DEBUG level, and returns the resultant process output as a string. |
There was a problem hiding this comment.
I: creature comfort so we just have less output since this now runs every time we get the pyenv version
d-ryan-ashcraft
force-pushed
the
47-pyenv-misconfiguration-check
branch
from
fbb23fd to
7c38b53
Compare
peter-mcclonski
approved these changes
Sep 7, 2023
ewilkins-csi
reviewed
Sep 7, 2023
habushu-maven-plugin/src/main/java/org/technologybrewery/habushu/exec/PythonVersionHelper.java
Outdated
Show resolved
Hide resolved
ewilkins-csi
approved these changes
Sep 7, 2023
d-ryan-ashcraft
force-pushed
the
47-pyenv-misconfiguration-check
branch
from
7c38b53 to
e9cb6eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.