#39 ⬆️ update default python version from 3.9.16 to 3.11.4 to… #42
Conversation
…latest binary installer is available; ✨ catch poetry check error and perform remediation
d-ryan-ashcraft
force-pushed
the
39-default-python-version-bump
branch
from
4ff66d3 to
b5da2db
Compare
| @@ -21,27 +21,35 @@ public class InitializeHabushuMojo extends AbstractHabushuMojo { | |||
| @Override | |||
| public void execute() throws MojoExecutionException, MojoFailureException { | |||
|
|
|||
There was a problem hiding this comment.
I (Informational): recommend hiding whitespace
| PoetryCommandHelper poetryHelper = createPoetryCommandHelper(); | ||
| try { | ||
| poetryHelper.execute(Arrays.asList("check")); | ||
| } catch (HabushuException e) { |
There was a problem hiding this comment.
Seems to occur when you update the minimum python version in your pyproject.toml. It is easy to remiediate, so we catch the error and have poetry resync pypoject.toml and poetry.lock. If it were to fail during this, the error would be throw to the user.
| @@ -22,7 +22,7 @@ jobs: | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - name: Setup Pyenv | |||
There was a problem hiding this comment.
I (Informational): Need newer version of pyenv to install python 3.11.4
There was a problem hiding this comment.
Change seems fine in my limited experience. I've reviewed the build check and based on that clearing I'd say this is an approved change. I do still see a few spots in the habushu repo that reference python version of 3.10.4 like
cleanHabushuMojo.java and ValidatePyenvAndPoetryMojo.java, unless I'm misunderstanding things?
Those are examples of how to specify a non-default version of Python - I think it is useful they are different than the default version, but could be convinced otherwise as well. |
… ensure latest binary installer is available; ✨ catch poetry check error and perform remediation