#181 Update habushu container support to be more consistent across build platforms #182
Conversation
carter-cundiff
force-pushed
the
181-container-support-fix
branch
from
543c11f to
942f552
Compare
| arguments.add("config"); | ||
| arguments.add("virtualenvs.in-project"); | ||
| arguments.add("--local"); | ||
| String currentInProjectSetting = poetryHelper.execute(arguments); |
There was a problem hiding this comment.
Q: This is just to ensure we've got the poetry.toml file sync'd in the case that the user has a pre-existing .venv folder, but the config hasn't been set in the toml file? (Perhaps in the case it was manually modified to remove the config?)
There was a problem hiding this comment.
Correct, see comment below
|
Update draft release notes if you have access. If not let me know and I can update them. |
| // update the poetry config to match the useInProjectVirtualEnvironment boolean | ||
| if (this.useInProjectVirtualEnvironment && Boolean.FALSE.equals(Boolean.valueOf(currentInProjectSetting))) { | ||
| getLog().info("Configuring Poetry to use an in-project virtual environment..."); | ||
| configureVirtualEnvironmentsInProject(true); |
There was a problem hiding this comment.
I: Previously we only updated the poetry config for virtualenvs.in-project when a .venv didn't exist. This will set the virtualenvs.in-project regardless of if a .venv exists, ensuring the poetry.toml always matches the value of useInProjectVirtualEnvironment.
There was a problem hiding this comment.
We should test going both in-project versus default location and back for this. I recall that the original logic accounted for a challenge in that sequencing.
There was a problem hiding this comment.
Tested going back and forth between in project and external virtual environments without any issue. Both the current version (2.16.1) and the updated version (2.17.0-SNAPSHOT) showed the following behavior:
Case 1: external -> in project
- External environment is deleted
- In project environment is created and used
poetry.tomlis updated within-project = true
Case 2: in project -> external
- In project environment is deleted
- External environment is created and used
poetry.tomlis updated within-project = false
The only difference in behavior is if you have habushu.useInProjectVirtualEnvironment=true and don't have in-project = true in your poetry.toml but have an in project environment:
2.17.0-SNAPSHOTwill addin-project = trueto yourpoetry.tomland use the in project environment2.16.1will leave thepoetry.tomlunchanged and create an external environment, ignoring the in project environment
The current behavior of 2.16.1 seems like a bug to me that would be resolved with the 2.17.0-SNAPSHOT behavior.
Fixes #181