#161 ✨ migration dev-dependencies to group.dev.dependencies … #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-ryan-ashcraft
commented
Jun 25, 2024
| @@ -0,0 +1,157 @@ | |||
| package org.technologybrewery.habushu.migration; | |||
There was a problem hiding this comment.
I (Informational): refactored existing group migration to an abstract class to make it easy to add multiple
d-ryan-ashcraft
force-pushed
the
161-dev-deps-migration
branch
from
829ff26 to
f858fba
Compare
Cho-William
reviewed
Jun 25, 2024
...aven-plugin/src/test/resources/migration/dev-dependencies/with-no-dev-dependenies-group.toml
Outdated
Show resolved
Hide resolved
Cho-William
reviewed
Jun 25, 2024
| ] | ||
| }, | ||
| { | ||
| "name": "dev-dependencies-preferred-poetry-approach-group-migration", |
There was a problem hiding this comment.
A: I personally think this reads better, but no worries if we think the original naming is better
Suggested change
| "name": "dev-dependencies-preferred-poetry-approach-group-migration", | |
| "name": "preferred-poetry-approach-dev-dependencies-group-migration", |
There was a problem hiding this comment.
TomAto-tOmato - gonna leave it the way it is
Cho-William
reviewed
Jun 25, 2024
...rc/test/java/org/technologybrewery/habushu/migration/DevDependenciesGroupMigrationSteps.java
Outdated
Show resolved
Hide resolved
Cho-William
reviewed
Jun 25, 2024
...rc/test/java/org/technologybrewery/habushu/migration/DevDependenciesGroupMigrationSteps.java
Show resolved
Hide resolved
Cho-William
reviewed
Jun 25, 2024
...rc/test/java/org/technologybrewery/habushu/migration/DevDependenciesGroupMigrationSteps.java
Outdated
Show resolved
Hide resolved
Cho-William
approved these changes
Jun 25, 2024
ewilkins-csi
approved these changes
Jun 25, 2024
d-ryan-ashcraft
force-pushed
the
161-dev-deps-migration
branch
from
f858fba to
fbbedae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…automatically