Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

habushu clean no longer also cleans target #45

Closed
d-ryan-ashcraft opened this issue Sep 1, 2023 · 2 comments
Closed

habushu clean no longer also cleans target #45

d-ryan-ashcraft opened this issue Sep 1, 2023 · 2 comments
Assignees
@d-ryan-ashcraft
Labels
bug Something isn't working
Milestone
2.7.1

Comments

@d-ryan-ashcraft
Copy link
Contributor

Up to 2.6.0, Habushu's clean phase would clean both dist and target. Now it appears that only dist is being cleaned. This is a challenge for any standard Maven plugins being used in conjunction with Habushu that might leave things in the target folder.
@d-ryan-ashcraft d-ryan-ashcraft self-assigned this Sep 1, 2023
@d-ryan-ashcraft d-ryan-ashcraft added this to the 2.7.1 milestone Sep 1, 2023
@d-ryan-ashcraft d-ryan-ashcraft added the bug Something isn't working label Sep 1, 2023
@d-ryan-ashcraft
Copy link
Contributor Author

Recreated locally.

Steps to Recreate

  • Add a target folder to habushu-mixology
  • Add a file to the folder
  • Run mvn clean install
  • Validate that the folder still contains the file that was added - should have been cleaned out

d-ryan-ashcraft added a commit that referenced this issue Sep 1, 2023
@d-ryan-ashcraft
#45 🐛 update to also clean target in addition to dist
7ab1f2f
d-ryan-ashcraft added a commit that referenced this issue Sep 7, 2023
@d-ryan-ashcraft
#45 🐛 update to also clean target in addition to dist; with PR feedback
5316ca4
d-ryan-ashcraft added a commit that referenced this issue Sep 7, 2023
@d-ryan-ashcraft
Merge pull request #46 from TechnologyBrewery/45-fix-clean-plugin
ead26ad 
#45 🐛 update to also clean target in addition to dist
@d-ryan-ashcraft
Copy link
Contributor Author

CI build passed:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-ryan-ashcraft d-ryan-ashcraft

Labels
bug Something isn't working
Projects
None yet
Milestone
2.7.1
Development

No branches or pull requests
1 participant
@d-ryan-ashcraft