This repository has been archived by the owner on Sep 30, 2021. It is now read-only.
fix(getKarmaConfig): remove broken restartOnChange #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
commented
Nov 11, 2016
| @@ -16,6 +17,19 @@ module.exports = function test(karmaConfig) { | |||
| else reject(code) | |||
| }) | |||
|
|
|||
| if (karmaConfig.logLevel && karmaConfig.logLevel === 'DEBUG') { | |||
There was a problem hiding this comment.
Added some debug for future use. gen test --debug
| @@ -62,9 +62,6 @@ module.exports = function getKarmaConfig(config, webpackConfig) { | |||
| [config.test_entry]: ['webpack'], | |||
| }, | |||
| reporters: ['mocha', 'coverage'], | |||
| // When watching, Karma delays new runs until the current run is finished. | |||
| // Cancel the current run and start a new run immediately on file change. | |||
| restartOnFileChange: true, | |||
|
👻 |
|
ty ty! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is borked in Karma. It is causing tests to not run and the browser to disconnect.
karma-runner/karma#1640 (comment)