Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mama Mia Pizzeria bot by Anna H #142

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

Anna2024WebDev
Copy link

Copy link

@zoe-lindqvist zoe-lindqvist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code does a great job of guiding the user through the ordering process with clear prompts and feedback!
Great use of while loops, ensuring input validation, and last but not least I liked toLowerCase()_ method to handle case insensitivity. It really enhances the user experience.

Suggestions for improvement:

  • Consider using camelCase for variable naming. For example mealChoice instead of mealchoice.
  • Consider naming clarity. For example, the choice of mealchoice and mealType together might look misleading.

@Anna2024WebDev
Copy link
Author

Your code does a great job of guiding the user through the ordering process with clear prompts and feedback! Great use of while loops, ensuring input validation, and last but not least I liked toLowerCase()_ method to handle case insensitivity. It really enhances the user experience.

Suggestions for improvement:

  • Consider using camelCase for variable naming. For example mealChoice instead of mealchoice.
  • Consider naming clarity. For example, the choice of mealchoice and mealType together might look misleading.

Hi @zoe-lindqvist Thanks a lot for your valuable feedback. I agree with you on the suggestions of improvements and have already implemented them. Thank you for noticing!

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job with this project Anna! 🍕

JavaScript

  • Nice usage of while loops to ensure the user inputs valid choices ⭐
  • It’s great that you used .toLowerCase() when confirming the order to ensure the input is case-insensitive. This is a good practice when working with user input since users may not always type responses in the expected format!

Clean Code

  • Nice and descriptive naming of variables!
  • Well-indented code which improves readability

Keep up the good work! 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants