Chim/feature/setup notification repository #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilymclean
requested changes
Sep 14, 2024
There was a problem hiding this comment.
Your code is clean and readable, your database transactions are safely designed, this is generally a good contribution. Make the changes to the endpoints to make them secure and follow RESTful conventions, and likewise move the check_user_exists function somewhere more conceptually relevant.
emilymclean
requested changes
Sep 17, 2024
emilymclean
approved these changes
Sep 19, 2024
5oappy
pushed a commit
that referenced
this pull request
Sep 27, 2024
Add fcm token repository and Api endpoint for register and unregister fcm token. Add a new domain FCMToken for representing fcm token. - [Jira](https://fireapp-emergiq-2024.atlassian.net/jira/software/projects/FIR/boards/2?selectedIssue=FIR-99) - [Documentation](https://fireapp-emergiq-2024.atlassian.net/wiki/spaces/fireapp202/pages/99713028/Notification+Feature) merged new changes from origin/main into branch to make merging more seamless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add fcm token repository and Api endpoint for register and unregister fcm token.
Add a new domain FCMToken for representing fcm token.
Issue ticket number and link